Changeset 2580

Timestamp:

03/04/10 21:29:51 (2 years ago)

Author:

karpet

Message:

fix bug when no default_field defined

Location:

Search-Query-Dialect-KSx/trunk

Files:

• lib/Search/Query/Dialect/KSx.pm (modified) (1 diff)
• t/01-parser.t (modified) (2 diffs)

Search-Query-Dialect-KSx/trunk/lib/Search/Query/Dialect/KSx.pm

@@ -155 +155 @@
 
     # make sure we have a field
-    my $default_field = $self->default_field || $self->parser->default_field;
-    if ( defined $default_field and !ref($default_field) ) {
-        $default_field = [$default_field];
-    }
+    my $default_field 
+        = $self->default_field
+        || $self->parser->default_field
+        || undef;    # not empty string or 0
     my @fields
         = $clause->{field}

Search-Query-Dialect-KSx/trunk/t/01-parser.t

@@ -3 +3 @@
 use strict;
 use warnings;
-use Test::More tests => 54;
+use Test::More tests => 57;
 use Data::Dump qw( dump );
 
@@ -205 +205 @@
 is( $fuzzy_ks->to_string, $fuzzy_query->stringify,
     "stringification matches" );
+
+# no fields defined
+ok( my $nofields_parser = Search::Query->parser( dialect => 'KSx', ),
+    "nofields parser" );
+ok( my $nofields_query = $nofields_parser->parse('foo'), "parse nofields" );
+is( $nofields_query, "foo", "stringify nofields_query" );